New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TreeView decorators #658

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@philschatz

philschatz commented Nov 23, 2015

Allows a package to add/remove a class on the Directory or File similar to the FileIcon and the VCS updateStatus methods in tree-view.

FileIcon and the VCS updateStatus annotate the files/directories in different ways:

  • FileIcon sets the class once based on the filename but does not allow other packages to change the class on their own.
  • VCS methods in TreeView could be abstracted as a provider for decorating files and directories; most of the code so far in this Pull Request is copy/pasta from File::updateStatus.

Any thoughts on consolidating FileIcon and updateStatus methods by adding a decorator similar (but much simpler) to TextEditor::markBufferRange and TextEditor::decorateMarker?

This is a spike, mostly to see if there is interest before continuing

See the pull-requests package for the motivation for adding decorators:

pull-requests

@philschatz philschatz changed the title from [WIP] Add support for TreeView decorators to Add support for TreeView decorators Mar 2, 2016

@philschatz

This comment has been minimized.

Show comment
Hide comment
@philschatz

philschatz Mar 9, 2016

Any updates on this? I noticed other Pull Requests were given tags but maybe this one was skipped?

Also, there was a merge conflict in the tests but I rebased to remove the conflict. Thanks for making such a hackable editor!

philschatz commented Mar 9, 2016

Any updates on this? I noticed other Pull Requests were given tags but maybe this one was skipped?

Also, there was a merge conflict in the tests but I rebased to remove the conflict. Thanks for making such a hackable editor!

@lee-dohm lee-dohm added the atom label Mar 9, 2016

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Mar 9, 2016

Member

I've put it in the queue for review. I'm not sure when the team will be able to get to it, but it looks interesting!

Member

lee-dohm commented Mar 9, 2016

I've put it in the queue for review. I'm not sure when the team will be able to get to it, but it looks interesting!

@dac09

This comment has been minimized.

Show comment
Hide comment
@dac09

dac09 Apr 2, 2016

I've not dived into writing atom plugins yet - so can't comment on the code, but going to request the atom team to have a look 👍

dac09 commented Apr 2, 2016

I've not dived into writing atom plugins yet - so can't comment on the code, but going to request the atom team to have a look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment