New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #21

merged 3 commits into from Nov 10, 2017


None yet
1 participant

50Wliu commented Nov 10, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

  • Destroy modal panel when package is deactivated
  • Allow core:cancel to destroy the modal as soon as it is created instead of registering the command right before the modal is destroyed...
  • Clarify the existence of the runBufferedProcess helper function
  • Remove excessive and potentially confusing array destructuring in specs

Alternate Designs

I considered also killing the apm process on deactivation but that might lead to an inconsistent node_modules state.


Easier to follow code.

Possible Drawbacks


Applicable Issues


50Wliu added some commits Nov 10, 2017

@50Wliu 50Wliu merged commit 4a706df into master Nov 10, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
continuous-integration/appveyor/pr AppVeyor build succeeded

@50Wliu 50Wliu deleted the wl-cleanup branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment