New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install devDependencies as well #22

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 10, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

NODE_ENV needs to be set to development in order for dev dependencies to be installed. So this PR assigns the existing process.env to a new object and then overwrites the new object's NODE_ENV with 'development'.

Alternate Designs

None.

Benefits

All dependencies will be installed.

Possible Drawbacks

Slower install time due to the extra time needed to install dev dependencies.

Applicable Issues

None.

@50Wliu 50Wliu merged commit 97359c9 into master Nov 10, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-dev-dependencies branch Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment