New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unobtrusive status bar tile instead of modal panel #23

Merged
merged 1 commit into from Nov 11, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 10, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Instead of creating a modal panel which effectively prevents the developer from continuing to work while his packages are installing, simply add a little spinner in the status bar to indicate that package installation is in progress. Looks like the following:
status-bar-update-package-dependencies

Alternate Designs

None.

Benefits

Updating package dependencies should no longer interrupt your workflow.

Possible Drawbacks

None.

Applicable Issues

None.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Nov 10, 2017

Member

I had to use vertical-align: text-bottom to correctly align the spinner. All the other options like middle didn't center it in the middle.

Member

50Wliu commented Nov 10, 2017

I had to use vertical-align: text-bottom to correctly align the spinner. All the other options like middle didn't center it in the middle.

@50Wliu 50Wliu merged commit 97252ac into master Nov 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-status-bar-tile branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment