New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error output if `apm install` fails #25

Merged
merged 1 commit into from Nov 11, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 11, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Previously, if apm install failed, there would be no indication as to why. Now all stderr output is displayed in the notification to aid debugging.

Alternate Designs

None.

Benefits

More accessible error output.

Possible Drawbacks

Very large failure notifications.

Applicable Issues

None.

@50Wliu 50Wliu merged commit 09792df into master Nov 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-error-notification-detail branch Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment