Skip to content
This repository has been archived by the owner. It is now read-only.

Implement 'I' (insert at beginning of line) #49

Merged
merged 2 commits into from Feb 28, 2014
Merged

Conversation

@codingcampbell
Copy link
Contributor

codingcampbell commented Feb 27, 2014

I am a heavy user of A and I was missing its sisterI command :)

@dougblack
Copy link
Contributor

dougblack commented Feb 27, 2014

+1 this is a must-have.

@jaymiejones86
Copy link

jaymiejones86 commented Feb 27, 2014

Big +1 on this one.

@adiospace
Copy link
Contributor

adiospace commented Feb 27, 2014

+1

2 similar comments
@ruedap
Copy link
Contributor

ruedap commented Feb 27, 2014

+1

@svnlto
Copy link

svnlto commented Feb 27, 2014

+1

@jessmartin
Copy link

jessmartin commented Feb 27, 2014

First thing I noticed within 20 seconds of using Atom. Merge please! 😄

Atom is the 💩 btw!

@ejlangev
Copy link

ejlangev commented Feb 27, 2014

+1

1 similar comment
@lodestone
Copy link

lodestone commented Feb 27, 2014

+1

@mcolyer
Copy link
Contributor

mcolyer commented Feb 28, 2014

This makes sense but I'd like to see a spec for it first before merging.

@DySFunction can you work something up similar to https://github.com/atom/vim-mode/blob/master/spec/operators-spec.coffee#L388?

@codingcampbell
Copy link
Contributor Author

codingcampbell commented Feb 28, 2014

@mcolyer sure thing, please see the revised commits.

FYI the wording in README made me think writing a spec wasn't possible for me (as someone who only has access to the binary download):

Important you'll need to be running a locally built version of Atom to run tests

Thanks!

@mcolyer
Copy link
Contributor

mcolyer commented Feb 28, 2014

Opps, let me get that out of there right away.

@mcolyer mcolyer added the enhancement label Feb 28, 2014
@mcolyer
Copy link
Contributor

mcolyer commented Feb 28, 2014

Great work, merging now.

I also forgot to mention adding a line to the docs but since that was my oversight I'll add it after merging.

mcolyer added a commit that referenced this pull request Feb 28, 2014
Implement 'I' (insert at beginning of line)
@mcolyer mcolyer merged commit c5f5232 into atom:master Feb 28, 2014
mcolyer added a commit that referenced this pull request Feb 28, 2014
chadkouse added a commit to chadkouse/vim-mode that referenced this pull request Mar 2, 2014
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request atom#94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for atom#81 & atom#84
  Revert pull request atom#92
  Add changelog note for atom#59
  Add changelog notes for atom#76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for atom#71
  Document existing commands
  Add documentation for atom#49
  Add a changelog note for atom#48
  Move left after exiting insert mode
  ...
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
Implement 'I' (insert at beginning of line)
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request atom#94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for atom#81 & atom#84
  Revert pull request atom#92
  Add changelog note for atom#59
  Add changelog notes for atom#76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for atom#71
  Document existing commands
  Add documentation for atom#49
  Add a changelog note for atom#48
  Move left after exiting insert mode
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.