This repository has been archived by the owner. It is now read-only.

Implement 'I' (insert at beginning of line) #49

Merged
merged 2 commits into from Feb 28, 2014

Conversation

Projects
None yet
10 participants
@codingcampbell
Contributor

codingcampbell commented Feb 27, 2014

I am a heavy user of A and I was missing its sisterI command :)

@dougblack

This comment has been minimized.

Show comment
Hide comment
@dougblack

dougblack Feb 27, 2014

Contributor

+1 this is a must-have.

Contributor

dougblack commented Feb 27, 2014

+1 this is a must-have.

@jaymiejones86

This comment has been minimized.

Show comment
Hide comment
@jaymiejones86

jaymiejones86 Feb 27, 2014

Big +1 on this one.

Big +1 on this one.

@adiospace

This comment has been minimized.

Show comment
Hide comment
@adiospace

adiospace Feb 27, 2014

Contributor

+1

Contributor

adiospace commented Feb 27, 2014

+1

@ruedap

This comment has been minimized.

Show comment
Hide comment
@ruedap

ruedap Feb 27, 2014

Contributor

+1

Contributor

ruedap commented Feb 27, 2014

+1

@svnlto

This comment has been minimized.

Show comment
Hide comment

svnlto commented Feb 27, 2014

+1

@jessmartin

This comment has been minimized.

Show comment
Hide comment
@jessmartin

jessmartin Feb 27, 2014

First thing I noticed within 20 seconds of using Atom. Merge please! 😄

Atom is the 💩 btw!

First thing I noticed within 20 seconds of using Atom. Merge please! 😄

Atom is the 💩 btw!

@ejlangev

This comment has been minimized.

Show comment
Hide comment

+1

@lodestone

This comment has been minimized.

Show comment
Hide comment

+1

@mcolyer

This comment has been minimized.

Show comment
Hide comment
@mcolyer

mcolyer Feb 28, 2014

Contributor

This makes sense but I'd like to see a spec for it first before merging.

@DySFunction can you work something up similar to https://github.com/atom/vim-mode/blob/master/spec/operators-spec.coffee#L388?

Contributor

mcolyer commented Feb 28, 2014

This makes sense but I'd like to see a spec for it first before merging.

@DySFunction can you work something up similar to https://github.com/atom/vim-mode/blob/master/spec/operators-spec.coffee#L388?

@codingcampbell

This comment has been minimized.

Show comment
Hide comment
@codingcampbell

codingcampbell Feb 28, 2014

Contributor

@mcolyer sure thing, please see the revised commits.

FYI the wording in README made me think writing a spec wasn't possible for me (as someone who only has access to the binary download):

Important you'll need to be running a locally built version of Atom to run tests

Thanks!

Contributor

codingcampbell commented Feb 28, 2014

@mcolyer sure thing, please see the revised commits.

FYI the wording in README made me think writing a spec wasn't possible for me (as someone who only has access to the binary download):

Important you'll need to be running a locally built version of Atom to run tests

Thanks!

@mcolyer

This comment has been minimized.

Show comment
Hide comment
@mcolyer

mcolyer Feb 28, 2014

Contributor

Opps, let me get that out of there right away.

Contributor

mcolyer commented Feb 28, 2014

Opps, let me get that out of there right away.

@mcolyer mcolyer added the enhancement label Feb 28, 2014

@mcolyer

This comment has been minimized.

Show comment
Hide comment
@mcolyer

mcolyer Feb 28, 2014

Contributor

Great work, merging now.

I also forgot to mention adding a line to the docs but since that was my oversight I'll add it after merging.

Contributor

mcolyer commented Feb 28, 2014

Great work, merging now.

I also forgot to mention adding a line to the docs but since that was my oversight I'll add it after merging.

mcolyer added a commit that referenced this pull request Feb 28, 2014

Merge pull request #49 from dysfunction/master
Implement 'I' (insert at beginning of line)

@mcolyer mcolyer merged commit c5f5232 into atom:master Feb 28, 2014

mcolyer added a commit that referenced this pull request Feb 28, 2014

chadkouse added a commit to chadkouse/vim-mode that referenced this pull request Mar 2, 2014

Merge branch 'master' into linewisePaste
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request #94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for #81 & #84
  Revert pull request #92
  Add changelog note for #59
  Add changelog notes for #76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for #71
  Document existing commands
  Add documentation for #49
  Add a changelog note for #48
  Move left after exiting insert mode
  ...

MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015

Merge pull request #49 from dysfunction/master
Implement 'I' (insert at beginning of line)

MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015

MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015

Merge branch 'master' into linewisePaste
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request #94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for #81 & #84
  Revert pull request #92
  Add changelog note for #59
  Add changelog notes for #76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for #71
  Document existing commands
  Add documentation for #49
  Add a changelog note for #48
  Move left after exiting insert mode
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.