Skip to content
This repository has been archived by the owner on Apr 6, 2018. It is now read-only.

Move to beginning of line #71

Merged
merged 2 commits into from Feb 28, 2014
Merged

Conversation

jroes
Copy link
Contributor

@jroes jroes commented Feb 27, 2014

Hitting 0 takes you to the beginning of the line. When 0 is hit, we check to see if we're inside of a repeat (checking with topOperator). If so, we pass control over to repeatPrefix. Otherwise, we move to the beginning of the line. I originally attempted to use e.abortKeyBinding(), but repeatPrefix didn't ever fire. Not sure if that's a bug or my misunderstanding. All tests pass.

@jcurtis
Copy link
Contributor

jcurtis commented Feb 27, 2014

+1 for feature
still new to implementation

@mcolyer
Copy link
Contributor

mcolyer commented Feb 28, 2014

Fantastic work @jroes, you even got the docs ⚡.

mcolyer added a commit that referenced this pull request Feb 28, 2014
@mcolyer mcolyer merged commit f764801 into atom:master Feb 28, 2014
@mcolyer
Copy link
Contributor

mcolyer commented Feb 28, 2014

Just saw the note about e.abortKeyBinding(). I'm not exactly sure how you were using it but if you explain more I should be able to determine if there's a bug there (I'm guessing it's a limitation of the current keybinding system).

mcolyer pushed a commit that referenced this pull request Feb 28, 2014
chadkouse added a commit to chadkouse/vim-mode that referenced this pull request Mar 2, 2014
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request atom#94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for atom#81 & atom#84
  Revert pull request atom#92
  Add changelog note for atom#59
  Add changelog notes for atom#76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for atom#71
  Document existing commands
  Add documentation for atom#49
  Add a changelog note for atom#48
  Move left after exiting insert mode
  ...
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
* master: (27 commits)
  Tiny fix for CHANGELOG
  Tiny fix for README
  Revert pull request atom#94
  Bump Atom dependency to latest (0.62)
  Prepare 0.7.2 release
  Mark changelog as 0.7.2
  Add spec for selection behavior in command-mode
  Remove extra whitespace
  Add changelog notes for atom#81 & atom#84
  Revert pull request atom#92
  Add changelog note for atom#59
  Add changelog notes for atom#76
  Fix a test failure on 0.62
  Add gt, gT keybindings to switch tabs
  motion: added { for movement to previous paragraph
  Update changelog for atom#71
  Document existing commands
  Add documentation for atom#49
  Add a changelog note for atom#48
  Move left after exiting insert mode
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants