Highlight search results

[jazzpi]

This highlights search results (from the / and */# keybindings) using the Atom Decoration API. The styles were copied from the find-and-replace package.

Currently, it only updates when searching for a string (also empty string) with / or using */#. It doesn't update when using n/N or simply inserting the string again.

[tonatiuh]

+1 for this.

[johnelliott]

+1 ❤️

[amiorin]

+1

[dsifford]

What can I do to help get this merged? This is sorely needed!

@jazzpi I'm assuming this PR adds result highlighting as you type (a la vim in the terminal)? If so, you are the man! (If not, you're probably still the man...).

[alextes]

Same, if there's anything I can do to help the merge along.. Seems this has been lying in wait for quite a while.

[jazzpi]

@dsifford No, it doesn't do that sadly. This PR simply adds highlights to all results when vim-mode searches, but it only searches when you press /, ?, * or #.

[dsifford]

@jazzpi Ah, bummer. That's the one feature that keeps dragging me back to the terminal. 😞

[b6pzeusbc54tvhw5jgpyw8pwz2x6gs]

+1

[t9md]

FYI guys, vim-mode-plus (forked version of vim-mode) already support highlightSearch and highlight as you type (if you enable incrementalSearch config option) and more.
Don't ask me why I started forked project, I've asked hundred times and put note on README.md for that 😄

[dsifford]

@t9md I've been using your fork for a few weeks and can confirm that it's friggen' awesome. Nice work!

[dragonxlwang]

anytime this PR would get merged soon?

[dragonxlwang]

I found there is an unwanted behavior: after using atom's generic find: cmd+f and use vim-mode's find again, the highlight no longer show up anymore... Is that supposed to be so?

[lee-dohm]

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!