Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix field names used by the welcome package metric events #73
Description of the Change
This PR includes three changes:
The changes of the metric events field names have been done to match the names that
Ideally the name of the fields would be fixed by
jasonrudolph left a comment
I looked over the code, and I just have one question: Can you describe how you'll verify that these changes are having the desired effect? (Note: This reminds me that we should update the pull request templates to prompt for a verification plan.
I've added a test plan on this PR. I haven't added many details about how to check that the events get propagated internally but feel free to ping me if you're interested in knowing how do I check it
I completely agree about adding verification steps to the PR templates!