New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also accept text.md as a valid Markdown scope #177

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@burodepeper
Contributor

burodepeper commented Jun 15, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Appended an if statement to allow for either source.gfm or text.md to be valid scope names for Markdown files.

Alternate Designs

Ideally, there'd be some standard to detect whether content is Markdown without relying on a scope name, which is a little overkill for this feature. I think the proposed change is acceptable.

Benefits

language-gfm isn't the only Markdown grammar. This patch helps serve a larger audience.

Possible Drawbacks

None?

Applicable Issues

@daviwil

This comment has been minimized.

Show comment
Hide comment
@daviwil

daviwil Sep 6, 2018

Member

Thanks a lot @burodepeper!

Member

daviwil commented Sep 6, 2018

Thanks a lot @burodepeper!

@daviwil daviwil merged commit 84ea711 into atom:master Sep 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment