Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't watch editors more than once if they're re-added to the workspace #71

Merged
merged 2 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@as-cii
Copy link
Member

as-cii commented Oct 20, 2017

This will prevent this package from providing its functionality to editors more than once in case they get added to the workspace, then removed from it and finally added back.

/cc: @nathansobo @jasonrudolph

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Nov 27, 2017

@as-cii 🚢?

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Nov 27, 2017

Also, supersedes and closes #52.

@as-cii as-cii merged commit 2f13396 into master Nov 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@as-cii as-cii deleted the as-dont-watch-same-editor branch Nov 28, 2017

@as-cii

This comment has been minimized.

Copy link
Member Author

as-cii commented Nov 28, 2017

Thanks for the ping on this, @50Wliu! 💯

This was referenced Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.