Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: Disable pointer events on .wrap-guide #72

Merged
merged 1 commit into from Nov 27, 2017
Merged

:bug: Disable pointer events on .wrap-guide #72

merged 1 commit into from Nov 27, 2017

Conversation

@ericcornelissen
Copy link
Contributor

@ericcornelissen ericcornelissen commented Nov 23, 2017

Description of the Change

Disable pointer events on the wrap guide in order to fix the bug where clicking precisely on the wrap guide (even though it is only a single pixel wide) would capture clicks, preventing you from switching lines in the TextEditor.

Alternate Designs

I'm not aware of any alternative solutions for this problem.

Benefits

Although it is a rare occurrence that one clicks precisely on that one pixel wide wrap-guide, it can happen and it is annoying if it doesn't do what you expect it to do.

Possible Drawbacks

None, as far as I know

Applicable Issues

None

Disable pointer events on the wrap guide in order to fix the bug where
clicking precisely on the wrap guide (even though it is only a single
pixel wide) would capture clicks, preventing you from switching lines in
the texteditor.
@50Wliu 50Wliu merged commit b7bc908 into atom:master Nov 27, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@50Wliu
Copy link
Member

@50Wliu 50Wliu commented Nov 27, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants