Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated `wrap-guide.columns` config option #73

merged 1 commit into from Nov 27, 2017


None yet
1 participant
Copy link

50Wliu commented Nov 27, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

wrap-guide.columns has been deprecated for almost three years now, so I think it's safe to finally remove it.

Alternate Designs



Removes a lot of legacy conversion code due to the continued existence of wrap-guide.columns.

Possible Drawbacks

Anyone still using the pattern property of wrap-guide.columns will have to manually update their config.

Applicable Issues


@50Wliu 50Wliu merged commit cf487a6 into master Nov 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-rm-deprecated-config branch Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.