Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Deactivate properly #76
Description of the Change
When deactivating, dispose of all subscriptions and remove wrap guide elements from the editor. Previously the only reason why the wrap guide "disappeared" was because its styling was removed - if you had some custom styling for it in your theme or
These changes necessitated converting the editor WeakSet introduced in #71 to an editor -> wrap guide Map.
I don't see any alternatives.
Proper package deactivation.
I'd like to say none. I'm still a bit fuzzy on the Map/WeakMap difference but it seems appropriate here to use a Map for the iteration on deactivate. There also shouldn't be a case where the only editor reference is contained in the Map.