Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for update promise after changing font size before updating guide #77

Merged
merged 2 commits into from Nov 28, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Copy link
Member

50Wliu commented Nov 28, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

By waiting for the editor update promise, we ensure that we are calculating the wrap guide position based on up-to-date editor measurements. This is particularly relevant for editors in the background, as those aren't updated until they become focused.

Also fixes a regression from #76.

Alternate Designs

None.

Benefits

Wrap guide changes position correctly after changing font size.

Possible Drawbacks

None.

Applicable Issues

Fixes #25

@50Wliu

This comment has been minimized.

Copy link
Member Author

50Wliu commented Nov 28, 2017

wrap-guide-font-size-update

@50Wliu 50Wliu merged commit 5ecb8ca into master Nov 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-update-on-font-size-change branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.