refactor([issue-912]): /simplify cleanups on the regen follow-ups#973
Merged
Conversation
Quality pass over #970/#971 (no behavior change): - MediaLightbox: drop the bespoke runRegen handler and reuse the existing runBusyAction for the Regenerate run button; collapse the three slider-bound fallback ternaries into one destructure with defaults. - regen.js buildRegenParams: store the trimmed prompt once instead of re-deriving the hasPrompt guard for prompt and negativePrompt. - local.js upscale: drop redundant Number() casts in the guard and use PNG compressionLevel 6 (sharp default) instead of 9 — near-identical size, faster re-encode on the render-completion path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quality-only pass (no behavior change) over the regen follow-ups (#970/#971), from running /simplify on the combined diff:
runBusyActionfor the Regenerate run button instead of a near-duplicaterunRegen; collapse three slider-bound fallback ternaries into one destructure-with-defaults.buildRegenParams— store the trimmed prompt once rather than re-deriving the guard for bothpromptandnegativePrompt.Number()casts and use PNGcompressionLevel: 6(sharp default) instead of9(near-identical size, faster re-encode on the completion path).Skipped (out of scope / not real): extracting a shared LabeledSlider/postProcessImage/regenDefaults module (bigger refactors touching unrelated files), clampRegenDimensions→imageEdgeSchema (validate vs clamp), fetching slider bounds inside SettingsPane (would duplicate the request; prop-threading matches the existing onClean/regenAvailable pattern).
Refs #912
Test plan
npm run buildsucceeds.