Add database setup #19

Merged
merged 2 commits into from Dec 24, 2012

Projects

None yet

2 participants

@sethvargo
Contributor
  • Adds a mysql and postgresql database user creation
  • Supports master (since database.yml.sqlite no longer exists)

⚠️ This breaks FC007 because it includes the mysql and postgresql recipes. However, it doesn't make sense to add them as dependencies in metadata.rb. Up to you.

@sethvargo sethvargo Add database setup
- Adds a mysql and postgresql database user creation
- Supports master (since database.yml.sqlite no longer exists)
30dc0db
@atomic-penguin atomic-penguin commented on an outdated diff Dec 6, 2012
README.md
@@ -144,6 +144,11 @@ Attributes
* gitlab['ssl\_req']
- Request subject used to generate a self-signed SSL certificate
+* gitlab['databsae']
atomic-penguin
atomic-penguin Dec 6, 2012 Owner

typo: databsae

Owner

What if I want to use sqlite as my data store? How does this change affect that default behavior?

Contributor

In master, sqlite is no longer supported as a datastore.

Contributor

I would recommend making this version a major bump, and indicate that master is a breaking change and no longer supports sqlite.

Owner

I would prefer to include the needed metadata, even if those recipes are conditionally included. I was also thinking about doing a run_once migration recipe, however the ordering of that could be awkward. I plan to merge, and release this change during holiday break. This is a high priority change, impacting a few other user issues, and I thank you for taking the time to implement this.

Contributor

Not a problem. Let me know if there's anything I can do to help.

@atomic-penguin atomic-penguin merged commit b3c63a2 into atomic-penguin:master Dec 24, 2012

1 check failed

default The Travis build failed
Details
@atomic-penguin atomic-penguin pushed a commit that referenced this pull request Jan 11, 2013
Eric G. Wolfe Issues #19 #25 #26
Release target, Gitlab CB v0.5.0

* Database back-end changes via @sethvargo
  - Adds a mysql and postgresql database creation
  - **Breaking change**: developed against githlabhq/master (sqlite no longer supported)

* Gitolite deploy changes via @dscheu
  - Deploy gitlabhq/gitolite, not sitaramc/gitolite

* Add configurable backup paths to Gitlab configuration via @dscheu
ed4cc27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment