New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up initial app boilerplate #1

Merged
merged 3 commits into from Jan 2, 2018

Conversation

Projects
None yet
2 participants
@sindresorhus
Member

sindresorhus commented Jan 1, 2018

This is the absolute minimal amount of boilerplate I could come up with. Other boilerplates, like electron-react-boilerplate, have a lot more boilerplate junk.

It will automatically build for all platforms on npm run release and the app auto-updates on new releases.

I added a temporary icon so it would look nice until we have an official one.

Live reloading is not yet done and will be finished in a follow-up PR later on.

@sindresorhus sindresorhus requested a review from lukechilds Jan 1, 2018

app/menu.js Outdated
electron.dialog.showMessageBox({
title: `About ${appName}`,
message: `${appName} ${app.getVersion()}`,
detail: 'Copyright © Luke Childs', // TODO: What should it say here?

This comment has been minimized.

@sindresorhus

sindresorhus Jan 1, 2018

Member

@lukechilds Who should be the copyright owner? I assume Pondsea or a company?

This comment has been minimized.

@lukechilds

lukechilds Jan 2, 2018

Member

I've asked Pondsea, leave it as me for now but will most likely be changed to Pondsea, Komodo Platform or SuperNET.

"author": {
"name": "Luke Childs",
"email": "lukechilds123@gmail.com",
"url": "http://lukechilds.co.uk"

This comment has been minimized.

@sindresorhus

sindresorhus Jan 1, 2018

Member

@lukechilds Who should be the copyright owner here?

@lukechilds

Great stuff, looks good. Still setting up my new MacBook but will test this out ASAP.

app/menu.js Outdated
electron.dialog.showMessageBox({
title: `About ${appName}`,
message: `${appName} ${app.getVersion()}`,
detail: 'Copyright © Luke Childs', // TODO: What should it say here?

This comment has been minimized.

@lukechilds

lukechilds Jan 2, 2018

Member

I've asked Pondsea, leave it as me for now but will most likely be changed to Pondsea, Komodo Platform or SuperNET.

@lukechilds

This comment has been minimized.

Member

lukechilds commented Jan 2, 2018

Any objections to using Yarn (and yarn.lock)? I think this project would benefit from a lockfile and really not keen on npm's approach.

Also possibly Prettier? I see XO has support built in now.

@sindresorhus

This comment has been minimized.

Member

sindresorhus commented Jan 2, 2018

I think this project would benefit from a lockfile and really not keen on npm's approach.

Their lockfiles are very similar now, but I'm good with either.

Also possibly Prettier? I see XO has support built in now.

It's only in XO master. I'll enable the prettier option when it's out in a new XO version in hopefully a week.

@sindresorhus

This comment has been minimized.

Member

sindresorhus commented Jan 2, 2018

Added Yarn lockfiles.

@lukechilds

This comment has been minimized.

Member

lukechilds commented Jan 2, 2018

Added Yarn lockfiles.

❤️

It's only in XO master. I'll enable the prettier option when it's out in a new XO version in hopefully a week.

Cool, no rush for that.

Make the Dark Mode toggle functional
To show off config and IPC

@lukechilds lukechilds merged commit aa9bcb0 into master Jan 2, 2018

@sindresorhus sindresorhus deleted the boilerplate branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment