New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include marketmaker binary for the current platform #124

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@sindresorhus
Member

sindresorhus commented Apr 18, 2018

I've manually tested this on all three platforms we support.

This reduces the app size from 160 MB to 153.5 MB 馃帀

!/app/marketmaker/bin/win32/libcurl.dll
!/app/marketmaker/bin/win32/nanomsg.dll
!/app/marketmaker/bin/win32/msvcp140.dll
!/app/marketmaker/bin/win32/vcruntime140.dll

This comment has been minimized.

@sindresorhus

sindresorhus Apr 18, 2018

Member

This is no longer needed now that we force marketmaker to write its junk files elsewhere: 6c791de

@sindresorhus sindresorhus requested a review from lukechilds Apr 18, 2018

@lukechilds

This comment has been minimized.

Member

lukechilds commented Apr 18, 2018

Awesome!

@sindresorhus sindresorhus merged commit 6305f28 into master Apr 18, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@sindresorhus sindresorhus deleted the strip-bins branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment