Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo design #200

Merged
merged 3 commits into from May 11, 2018

Conversation

Projects
None yet
2 participants
@sindresorhus
Copy link
Member

sindresorhus commented May 10, 2018

Created by Nadia Sotnikova: http://nadiasotnikova.com


screen shot 2018-05-10 at 14 24 56
screen shot 2018-05-10 at 14 25 10

@sindresorhus sindresorhus requested a review from lukechilds May 10, 2018

@lukechilds

This comment has been minimized.

Copy link
Member

lukechilds commented May 10, 2018

Odd, the logo SVG doesn't display properly for me in the markdown view

screen shot 2018-05-10 at 2 42 41 pm

If I view the file directly on GitHub it's ok

@sindresorhus

This comment has been minimized.

Copy link
Member Author

sindresorhus commented May 10, 2018

Weird. Seems like a GitHub bug. They recently started supporting relative links to SVG images.

Add new logo design
Created by Nadia Sotnikova: http://nadiasotnikova.com

@sindresorhus sindresorhus force-pushed the new-icon branch from 9f32e66 to a566f5a May 10, 2018

@sindresorhus

This comment has been minimized.

Copy link
Member Author

sindresorhus commented May 10, 2018

@sindresorhus

This comment has been minimized.

Copy link
Member Author

sindresorhus commented May 10, 2018

Turns out GitHub sanitizes SVG files, which breaks it. Here's what they changed: sindresorhus/sindre-playground@a337e26

@lukechilds

This comment has been minimized.

Copy link
Member

lukechilds commented May 10, 2018

They shouldn't do that, that's like linting code before showing it.

@sindresorhus

This comment has been minimized.

Copy link
Member Author

sindresorhus commented May 10, 2018

They have to sanitize the SVG since it could contain JS.

@lukechilds

This comment has been minimized.

Copy link
Member

lukechilds commented May 10, 2018

Ahhh, that makes sense.

sindresorhus added some commits May 11, 2018

@sindresorhus

This comment has been minimized.

Copy link
Member Author

sindresorhus commented May 11, 2018

I've contacted GitHub about the faulty sanitizer. Just using the PNG in the meanwhile.

@lukechilds

This comment has been minimized.

Copy link
Member

lukechilds commented May 11, 2018

Looks good!

@sindresorhus sindresorhus merged commit badfbde into master May 11, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sindresorhus sindresorhus deleted the new-icon branch May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.