New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates and instruction for adding a new currency #540

Merged
merged 5 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@sindresorhus
Member

sindresorhus commented Oct 4, 2018

No description provided.

@sindresorhus sindresorhus changed the title from Add issue templates and instruction for adding a new currency to [WIP] Add issue templates and instruction for adding a new currency Oct 4, 2018

sindresorhus added some commits Oct 4, 2018

@sindresorhus sindresorhus changed the title from [WIP] Add issue templates and instruction for adding a new currency to Add issue templates and instruction for adding a new currency Oct 4, 2018

@sindresorhus sindresorhus requested a review from lukechilds Oct 4, 2018

@kevva

kevva approved these changes Oct 4, 2018

@sindresorhus sindresorhus merged commit 5335529 into master Oct 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sindresorhus sindresorhus deleted the sindresorhus-patch-1 branch Oct 8, 2018

- When your pull request to `jl777/coins` has been merged, you can open a pull request on https://github.com/atomiclabs/hyperdex.
- Add the currency info [here](https://github.com/atomiclabs/hyperdex/blob/master/app/marketmaker/supported-currencies.js). *Note that the list is ordered alphabetically.*
- Add the block explorer [here](https://github.com/atomiclabs/hyperdex/blob/master/app/renderer/block-explorer.js). *Note that the list is ordered alphabetically.*
- In the pull request description, include information about the currency, like official website, CoinMarketCap page, Twitter, etc. Also include a link to your `jl777/coins` pull request.

This comment has been minimized.

@lukechilds

lukechilds Oct 8, 2018

Member

We should suggest linking to the cryptocurrency-icons issue here if applicable.

kevva added a commit that referenced this pull request Oct 9, 2018

Merge remote-tracking branch 'origin/master' into filter
* origin/master:
  Bump AVA and fix tests (#548)
  Add QMCoin (QMC) currency (#542)
  Add issue templates and instruction for adding a new currency (#540)
  Hide `Swap` view (#539)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment