Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketmaker v2 #602

Merged
merged 38 commits into from Jul 23, 2019

Conversation

@sindresorhus
Copy link
Member

commented Jun 3, 2019

This a continuation of #563.

The intention of this PR is to get HyperDEX with mm2 in a workable state.

I'm currently testing against mm2 d794c7b22.

Current plan:


Found new docs: https://github.com/KomodoPlatform/developer-docs/tree/mm/docs/basic-docs/atomic-swap-dex

@sindresorhus

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

@artemii235 Are the getendpoint and portfolio endpoints implemented in mm2?

This is what I'm getting:

Request: {method: "getendpoint", port: 65161}
Response: 500 {error: "Empty result from stats_JSON"}
Request: {method: "portfolio"}
Response: 500 {error: "Empty result from stats_JSON"}

@sindresorhus sindresorhus referenced this pull request Jun 3, 2019

Closed

Marketmaker v2 test #563

@sindresorhus

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

In the mm2 codebase, getendpoint is commented out, so I guess not.

@artemii235 Any plans to implement it?

/*
        else if ( strcmp(method,"getendpoint") == 0 )
        {
            int32_t err,mode; uint16_t wsport = 5555; char endpoint[64],bindpoint[64];
            if ( juint(argjson,"port") != 0 )
                wsport = juint(argjson,"port");
            retjson = cJSON_CreateObject();
            if ( IPC_ENDPOINT >= 0 )
            {
                jaddstr(retjson,"error","IPC endpoint already exists");
                jaddnum(retjson,"socket",IPC_ENDPOINT);
            }
            else
//...
*/
@lukechilds

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Also, we make heavy use of the WebSocket port in mmv1 to get updates on trade status and update the UI. I didn't see any mention of WebSocket usage in the updated docs.

@lukechilds

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

And +1 on committing MM commit hash. We need reproducible builds otherwise we're going to have a nightmare tracking down bugs.

@artemii235

This comment has been minimized.

Copy link

commented Jun 17, 2019

Hi, getendpoint and portfolio calls are not working right now. API was changed significantly, the docs can be found here: https://github.com/artemii235/developer-docs/blob/mm/docs/basic-docs/atomic-swap-dex/dex-api.md. Please note that docs might miss some calls still, I will actualize it on this week.

@sindresorhus sindresorhus force-pushed the marketmaker-v2 branch from d65bd05 to 1d0c3b3 Jun 28, 2019

@sindresorhus sindresorhus force-pushed the marketmaker-v2 branch 2 times, most recently from 3cdfe21 to 1f5dc6b Jul 12, 2019

sindresorhus added some commits Jul 14, 2019

Remove average volume from the exchange
> `avevolume` doesn't make any sense now as it means average utxo size which is not applicable to MM2 at all. MM2 doesn't need UTXO splitting, it can work if address has only 1 UTXO. So this field will be removed.

@sindresorhus sindresorhus force-pushed the marketmaker-v2 branch from dc3e3e7 to 9e7dc87 Jul 20, 2019

sindresorhus added some commits Jul 20, 2019

Use a new database entry for swaps
Since it's not compatible with the previous HyperDEX versions.

@sindresorhus sindresorhus merged commit be3575b into master Jul 23, 2019

0 of 2 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details

@sindresorhus sindresorhus deleted the marketmaker-v2 branch Jul 23, 2019

@sindresorhus

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

This is good enough to merge now. I'll continue to push improvements to master. (Want to merge so we can start having nightly builds from master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.