From b9da11e6d8d5fa4b0f063b2db0e03bc9ef89ab6f Mon Sep 17 00:00:00 2001
From: atomiks <cc.glows@gmail.com>
Date: Mon, 15 Apr 2019 19:19:27 +1000
Subject: [PATCH] Make <TippyGroup /> updateable

---
 package.json            |  2 +-
 src/TippyGroup.js       |  5 +----
 test/TippyGroup.test.js | 28 ++++++++++++++++++++++++++++
 3 files changed, 30 insertions(+), 5 deletions(-)

diff --git a/package.json b/package.json
index d906c90..5cbb5f6 100644
--- a/package.json
+++ b/package.json
@@ -46,7 +46,7 @@
   },
   "dependencies": {
     "prop-types": "^15.6.2",
-    "tippy.js": "^4.2.1"
+    "tippy.js": "^4.3.0"
   },
   "peerDependencies": {
     "react": ">=16.8",
diff --git a/src/TippyGroup.js b/src/TippyGroup.js
index 081dbb3..c36b0b3 100644
--- a/src/TippyGroup.js
+++ b/src/TippyGroup.js
@@ -7,10 +7,7 @@ export default function TippyGroup({ children, ...props }) {
 
   useEffect(() => {
     tippy.group(instancesRef.current, props)
-    return () => {
-      instancesRef.current = null
-    }
-  }, [])
+  })
 
   return Children.map(children, child => {
     return cloneElement(child, {
diff --git a/test/TippyGroup.test.js b/test/TippyGroup.test.js
index 43ca2c4..7d43c5c 100644
--- a/test/TippyGroup.test.js
+++ b/test/TippyGroup.test.js
@@ -65,4 +65,32 @@ describe('<TippyGroup />', () => {
 
     render(<App />)
   })
+
+  test('props are updateable', () => {
+    const delay = 1000
+    const nextDelay = 500
+    const { container, rerender } = render(
+      <TippyGroup delay={delay}>
+        <Tippy content="toolip">
+          <button />
+        </Tippy>
+        <Tippy content="toolip">
+          <button />
+        </Tippy>
+      </TippyGroup>,
+    )
+    const instance = container.querySelector('button')._tippy
+    expect(instance.props.delay).toBe(delay)
+    rerender(
+      <TippyGroup delay={nextDelay}>
+        <Tippy content="tooltip">
+          <button />
+        </Tippy>
+        <Tippy content="toolip">
+          <button />
+        </Tippy>
+      </TippyGroup>,
+    )
+    expect(instance.props.delay).toBe(nextDelay)
+  })
 })