New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Gitlab support #399

Merged
merged 21 commits into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@lievendoclo
Copy link
Contributor

lievendoclo commented Nov 8, 2018

No description provided.

lievendoclo added some commits Nov 5, 2018

Add comments
Fix usage of mapped parameters
Use url.resolve
Add HTTP method to MR call
@ddgenome

This comment has been minimized.

Copy link
Member

ddgenome commented Nov 8, 2018

The name of this PR doesn't seem quite right.

@lievendoclo lievendoclo changed the title TSLint Add initial Gitlab support Nov 8, 2018

lievendoclo added some commits Nov 8, 2018

@cdupuis

This comment has been minimized.

Copy link
Contributor

cdupuis commented Nov 9, 2018

We will merge that after the 1.0 release.

Show resolved Hide resolved lib/operations/common/AbstractRemoteRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/RepoId.ts Outdated
Show resolved Hide resolved lib/operations/common/gitlabRepoLoader.ts Outdated
Show resolved Hide resolved lib/operations/common/params/GitlabTargetsParams.ts Outdated
@ddgenome
Copy link
Member

ddgenome left a comment

Thanks for all the work. A few comments.

Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts Outdated
Show resolved Hide resolved lib/operations/common/params/GitlabTargetsParams.ts Outdated
Show resolved Hide resolved lib/operations/generate/GitlabRepoCreationParameters.ts
Show resolved Hide resolved lib/operations/common/GitlabRepoRef.ts
@cdupuis

This comment has been minimized.

Copy link
Contributor

cdupuis commented Nov 16, 2018

What is the state of this? We need this PR in master some time Monday. Any chance you could address the review comments @lievendoclo?

@lievendoclo

This comment has been minimized.

Copy link
Contributor Author

lievendoclo commented Nov 16, 2018

Comments processed

@ddgenome
Copy link
Member

ddgenome left a comment

Thanks.

@atomist-bot atomist-bot merged commit 322baae into master Nov 19, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

atomist-bot commented Nov 19, 2018

Pull request auto merged by Atomist.

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the gitlab-support branch Nov 19, 2018

atomist-bot added a commit that referenced this pull request Nov 19, 2018

Changelog: #399 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment