New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Commit editMode and allow PR to specify base #414

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@cdupuis
Copy link
Contributor

cdupuis commented Dec 7, 2018

Adding the missing Commit edit mode instead of creating a BranchCommit manually. This is better for code completion.

Added support for target branch to PullRequest. Pass the targetBranch to the underlying PR creation functions in the repo refs.

Also fixed the calls to HttpClientFactory.create in the Gitlab support to pass the URL.

@ddgenome
Copy link
Member

ddgenome left a comment

LGTM

@cdupuis cdupuis removed the request for review from lievendoclo Dec 7, 2018

@cdupuis cdupuis merged commit 0c3a49d into master Dec 7, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the editModes-cleanup branch Dec 7, 2018

atomist-bot added a commit that referenced this pull request Dec 7, 2018

Changelog: #414 to changed, added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment