New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `targets.branch` and fix `project.id` to point to correct project #434

Merged
merged 2 commits into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

cdupuis commented Dec 20, 2018

Introduce targets.branch to instruct a CodeTransform to work off of a branch.

Fix project.id as 1st parameter to a CodeTransform to always point to the correct repo; and not - in the case of project creation - to the local cloned seed repo.

Removed default to merge into master for PullRequest edit mode.

@cdupuis cdupuis force-pushed the generate-repo-id branch from 6367f24 to 6b0705b Dec 20, 2018

@cdupuis cdupuis changed the title Autofix: tslint Introduce `targets.branch` and fix `project.id` to point to correct project Dec 20, 2018

@cdupuis cdupuis requested a review from ddgenome Dec 20, 2018

@ddgenome
Copy link
Member

ddgenome left a comment

Looks good. One question.

for (const queuedMessage of queuedMessages) {
await this.send(queuedMessage);
}
queuedMessages.forEach(this.send);

This comment has been minimized.

@ddgenome

ddgenome Dec 20, 2018

Member

Do you not want to await these?

await Promise.all(queuedMessages.forEach(this.send));

This comment has been minimized.

@cdupuis

cdupuis Dec 20, 2018

Author Contributor

No, this.send is void.

@ddgenome
Copy link
Member

ddgenome left a comment

LGTM

@atomist-bot atomist-bot merged commit f491c68 into master Dec 20, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

atomist-bot commented Dec 20, 2018

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the generate-repo-id branch Dec 20, 2018

atomist-bot added a commit that referenced this pull request Dec 20, 2018

Changelog: #434 to added, fixed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment