Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a dummy id to InMemoryProject #438

Merged
merged 3 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@jessitron
Copy link
Contributor

commented Jan 1, 2019

I know we did this at one point, but maybe we lost that branch

@jessitron jessitron requested a review from johnsonr Jan 1, 2019

Autofix: tslint
[atomist:generated] [atomist:autofix=tslint]
@cdupuis
Copy link
Contributor

left a comment

Maybe we don’t need the failing tests any more but we should fix them or remove. Probably the former.

@jessitron

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2019

@cdupuis you're right, I fixed the tests.
They don't run for me locally so I have to push and wait

@cdupuis

cdupuis approved these changes Jan 5, 2019

@cdupuis cdupuis merged commit 3da01bc into master Jan 7, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the nortissej/inMemProject branch Jan 7, 2019

atomist-bot added a commit that referenced this pull request Jan 7, 2019

Changelog: #438 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.