Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to better support targeting in command handlers #441

Merged
merged 3 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

commented Jan 7, 2019

No description provided.

@cdupuis cdupuis changed the title FIx assertion Various fixes to better support targeting in command handlers Jan 7, 2019

@cdupuis cdupuis force-pushed the remove-sha-branch-defaults branch from b3ffa4b to dffaaae Jan 7, 2019

@ddgenome

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

@cdupuis is this ready for review?

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2019

@ddgenome feel free to review. There isn't much there.

@ddgenome
Copy link
Member

left a comment

Looks good, although perhaps the branch needs rebased as it has some diffs that I thought were already on master.


- Provide a dummy id to InMemoryProject. [#438](https://github.com/atomist/automation-client/issues/438)

## [1.2.0](https://github.com/atomist/automation-client-ts/compare/1.1.0...1.2.0) - 2018-12-27

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 8, 2019

Member

Why would this be here?

owner: "dummyOwner",
repo: "dummyRepo",
url: "https://fakeGitHub.com/dummyOwner/dummyRepo",
}, ...files);

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 8, 2019

Member

Wasn't this from another commit?

@@ -1,6 +1,6 @@
{
"name": "@atomist/automation-client",
"version": "1.2.0",
"version": "1.2.1",

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 8, 2019

Member

? Maybe this branch needs rebased?

@cdupuis cdupuis force-pushed the remove-sha-branch-defaults branch from 6fa988b to b33951f Jan 8, 2019

@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit 1572620 into master Jan 8, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@atomist-bot atomist-bot deleted the remove-sha-branch-defaults branch Jan 8, 2019

atomist-bot added a commit that referenced this pull request Jan 8, 2019

Changelog: #441 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.