Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow boolean and number parameters types in command requests #446
cdupuis left a comment
There are actually quite a more changes required to make that work properly (including tests which are missing from this PR and changes to the possible Arg values which can only be strings right now).
I have most of these changes pending on a local branch which also already includes the addition from this PR.
Note: Also the commit message and PR title indicate that this is a fix which IMHO it isn't. It is actually part of a completely new feature that was never really implemented: Support for other types in command handler parameter values besides strings. Hence I'd recommend to rename the commit and PR and also remove the dot at the end of the commit message.