Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failure logging for failed repo creations #461

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@ipcrm
Copy link
Contributor

commented Jan 22, 2019

Prior to this commit their was always a message that said 'Probably
exists' when a new repo failed to create from a generator. This was
misleading when the errors where coming from something like an
authorization problem (401). Updated to make it more generic and let
the err object provide the detail.

Update failure logging
Prior to this commit their was always a message that said 'Probably
exists' when a new repo failed to create from a generator.  This was
misleading when the errors where coming from something like an
authorization problem (401).  Updated to make it more generic and let
the `err` object provide the detail.

@ipcrm ipcrm requested a review from cdupuis Jan 22, 2019

@cdupuis cdupuis changed the title Update failure logging Update failure logging for failed repo creations Jan 22, 2019

@cdupuis
Copy link
Contributor

left a comment

LGTM

@atomist-bot atomist-bot merged commit 3c38746 into master Jan 22, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the ipcrm_logging_update branch Jan 22, 2019

atomist-bot added a commit that referenced this pull request Jan 22, 2019

Changelog: #461 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.