Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all deps including graphql-code-generator #474

Merged
merged 3 commits into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

commented Feb 15, 2019

This updates graphql-code-generator to latest version which needed a couple of changes:

  • now using the api to generate because otherwise we would need to have codegen.yml file in each repo 馃憥
  • I had to patch the web packed handlebar template to get the old bahavior back that generates optional properties on the generated types. Without that change, we have many compile errors in sdm and sdm-core then further.

Should we move forward with this for now? The motivation for the upgrade was a security vulnerability
on one of the old transitive dependencies. WDYT?

@cdupuis cdupuis requested a review from ddgenome Feb 15, 2019

@ddgenome
Copy link
Member

left a comment

A couple minor things and a question.

Show resolved Hide resolved bin/gql-gen.ts
Show resolved Hide resolved bin/gql-gen.ts
Show resolved Hide resolved bin/gql-gen.ts

@cdupuis cdupuis force-pushed the update-deps branch from 14cdccd to c042e7a Feb 17, 2019

cdupuis and others added some commits Feb 21, 2019

Autofix: NPM package lock
[atomist:generated] [atomist:autofix=npm_package_lock]
@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 21, 2019

@ddgenome any further thoughts on this?

@ddgenome

This comment has been minimized.

Copy link
Member

commented on 55c1496 Feb 21, 2019

Did npm update handlebars --depth 2 or just npm audit fix not fix it without requiring adding this dependency?

This comment has been minimized.

Copy link
Contributor Author

replied Feb 21, 2019

No, that did nothing as always.

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@ddgenome any more on this?

@ddgenome

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Sorry, this slipped off my radar. I clarified my question.

@ddgenome
Copy link
Member

left a comment

LGTM

@atomist-bot atomist-bot merged commit 76b4892 into master Feb 28, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the update-deps branch Feb 28, 2019

atomist-bot added a commit that referenced this pull request Feb 28, 2019

Changelog: #474 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.