Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo that crashed it #475

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@jessitron
Copy link
Contributor

commented Feb 16, 2019

We combined the strings so much that a few projects ran into InvalidStringLength and crashed.

This is extra funny because it was building a string
"inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable and inconceivable..."

Fix typo that crashed it
We combined the strings so much that a few projects ran into InvalidStringLength

@jessitron jessitron requested a review from cdupuis Feb 16, 2019

@atomist-bot atomist-bot merged commit b9623e3 into master Feb 19, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the nortissej/typoOfDoom branch Feb 19, 2019

atomist-bot added a commit that referenced this pull request Feb 19, 2019

Changelog: #475 to fixed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.