Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider and workspace create commands #61

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@cdupuis
Copy link
Contributor

commented Jan 15, 2019

This PR add two new commands:

  • workspace create creates a new workspace for the user
  • provider create creates a new SCM provider for convergence by an SDM

Question: Should those commands be create workspace and create provider instead of the currently proposed names.

@cdupuis cdupuis changed the title Polish message Add provider and workspace create commands Jan 15, 2019

@cdupuis cdupuis force-pushed the workspace-create branch from 6f0cb82 to fa0b411 Jan 15, 2019

@cdupuis cdupuis requested a review from ddgenome Jan 15, 2019

@cdupuis cdupuis force-pushed the workspace-create branch from d6add4b to aacc49d Jan 15, 2019

@ddgenome
Copy link
Member

left a comment

Looks good, a few minor things.

As for "create X" vs. "X create", I'd say if this is it, make it "create X" but if there are more X subcommands to come, e.g., "workspace delete" or "provider configure", then I'd say "X create".

Show resolved Hide resolved lib/config.ts
Show resolved Hide resolved lib/config.ts Outdated
Show resolved Hide resolved lib/provider.ts Outdated
Show resolved Hide resolved lib/provider.ts
bitbucket: {
label: "BitBucket",
create: UnsupportedProvider,
},*/

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 15, 2019

Member

Retain comment?

Show resolved Hide resolved lib/provider/github.ts

print.log(`Specify which GitHub organizations and/or repositories
you want to connect to Atomist. Please comma separated
names or glob patterns.`);

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 15, 2019

Member

"Please provide a comma separated list of organization names and/or glob patterns".

Show resolved Hide resolved lib/workspace.ts
/**
* Command-line options and arguments for workspace create
*/
export interface CreateOptions {

This comment has been minimized.

Copy link
@ddgenome

ddgenome Jan 15, 2019

Member

This is very similar to the CreateOptions in provider.ts. Should they be distinguished by adding the type, i.e., CreateWorkspaceOptions and CreateProviderOptions? Maybe this and the create function is why you did the import * from both of these?

@cdupuis cdupuis force-pushed the workspace-create branch from aacc49d to 150c063 Jan 15, 2019

@cdupuis cdupuis merged commit 3fb59ca into master Jan 15, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the workspace-create branch Jan 15, 2019

atomist-bot added a commit that referenced this pull request Jan 15, 2019

Changelog: #61 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.