Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry run and print current context to kube command #67

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

commented Mar 13, 2019

No description provided.

@ddgenome
Copy link
Member

left a comment

A couple things.

Show resolved Hide resolved lib/kube.ts Outdated
Show resolved Hide resolved lib/kube.ts Outdated
Show resolved Hide resolved lib/kube.ts Outdated

@cdupuis cdupuis force-pushed the dry-run-kube branch from 01a5494 to 15b3ad6 Mar 13, 2019

@cdupuis cdupuis requested a review from ddgenome Mar 13, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 13, 2019

@ddgenome could you review again. Comments should be addressed now.

@ddgenome
Copy link
Member

left a comment

LGTM

@atomist-bot atomist-bot merged commit 4d22069 into master Mar 13, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the dry-run-kube branch Mar 13, 2019

atomist-bot added a commit that referenced this pull request Mar 13, 2019

Changelog: #67 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.