Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce `createGoals` on SDM #183

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@cdupuis
Copy link
Contributor

commented Jul 5, 2019

This PR adds support to use createGoals function on the SDM instance inside configure:

export interface SpringGoals extends AllGoals {
    autofix: Autofix;
    version: Version;
    codeInspection: AutoCodeInspection;
    pushImpact: PushImpact;
    build: Build;
    dockerBuild: DockerBuild;
}

export const configuration = configure<SpringGoals>(async sdm => {

    const goals = await sdm.createGoals(SpringGoalCreator, SpringGoalConfigurer);

    return {
        check: {
            test: IsMaven,
            goals: [
                [goals.cancel, goals.autofix],
                [goals.codeInspection, goals.version, goals.fingerprint, goals.pushImpact],
            ],
        },
    ...
    };
});

This is entirely optional to use and backwards compatible.

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Removing auto-merge labels for now as I want to make some minor tweaks.

@ddgenome
Copy link
Member

left a comment

Looks good. No hard suggestions, just things to consider.

lib/machine/configure.ts Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved
lib/machine/configure.ts Outdated Show resolved Hide resolved

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch from a146bde to 30bfd8f Jul 6, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

Pull request was successfully rebased onto df3f4aa by @cdupuis:

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2019

Pull request was successfully rebased onto 5947a5f by @atomist-bot:

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch 2 times, most recently from e9bc019 to 228e650 Jul 7, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Pull request was successfully rebased onto 2f723d5 by @cdupuis:

  • 0c3caff Polish
  • 2f723d5 Fix label selector for time based job deletion

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch 2 times, most recently from d13668b to d14f1a4 Jul 8, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Pull request was successfully rebased onto 8238b3a by @cdupuis:

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch from d14f1a4 to 79fde7f Jul 8, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Pull request was successfully rebased onto 7255764 by @cdupuis:

  • 7255764 Use configuration passed into initialize

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch from 79fde7f to 7548cc2 Jul 8, 2019

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Pull request was successfully rebased onto f103285 by @cdupuis:

@cdupuis cdupuis force-pushed the create-goals-on-sdm branch from 7548cc2 to 3739efa Jul 8, 2019

@cdupuis cdupuis requested a review from ddgenome Jul 8, 2019

@ddgenome
Copy link
Member

left a comment

LGTM

@cdupuis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@cdupuis cdupuis merged commit dd99673 into master Jul 8, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the create-goals-on-sdm branch Jul 8, 2019

cdupuis pushed a commit that referenced this pull request Jul 8, 2019

Changelog: #183 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.