New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support canceling goals #80

Merged
merged 6 commits into from Nov 12, 2018

Conversation

Projects
None yet
4 participants
@cdupuis
Copy link
Contributor

cdupuis commented Nov 12, 2018

Part of atomist/sdm#572

cdupuis and others added some commits Nov 9, 2018

Autofix: tslint
[atomist:generated] [atomist:autofix=tslint]

@cdupuis cdupuis changed the title Check if goal is canceled before fulfilling Add support canceling goals Nov 12, 2018

@cdupuis cdupuis requested review from lievendoclo and ddgenome Nov 12, 2018

@ddgenome
Copy link
Member

ddgenome left a comment

Looks good. One possible error.

break;
case SdmGoalState.stopped:
failedGoalState = "stopped goals";
failedGoalDescription = "stopped goals";
failedGoalState = SdmGoalState.skipped;

This comment has been minimized.

@ddgenome

ddgenome Nov 12, 2018

Member

Should this be SdmGoalState.stopped?

This comment has been minimized.

@cdupuis

cdupuis Nov 12, 2018

Author Contributor

No, we are skipping because of a stopped goal. That is correct.

@ddgenome
Copy link
Member

ddgenome left a comment

I wish you could edit approval status on existing reviews.

@lievendoclo
Copy link
Contributor

lievendoclo left a comment

LGTM

@atomist-bot atomist-bot merged commit 8740b7f into master Nov 12, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

atomist-bot commented Nov 12, 2018

Pull request auto merged by Atomist.

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the cancel-goal branch Nov 12, 2018

atomist-bot added a commit that referenced this pull request Nov 12, 2018

Changelog: #80 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment