Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extension pack generator #236

Merged
merged 5 commits into from Mar 15, 2019

Conversation

Projects
None yet
5 participants
@jessitron
Copy link
Contributor

commented Feb 28, 2019

No description provided.

@jessitron jessitron requested a review from cdupuis Feb 28, 2019

@ddgenome

This comment has been minimized.

Copy link
Member

commented on 4c0116f Feb 28, 2019

This has no effect as it is included in "strict": true.

The whitespace changes undo what prettier does, so they will just get reverted the next time this file is edited, including the missing trailing newline.

jessitron and others added some commits Feb 28, 2019

Autofix: TypeScript imports
[atomist:generated] [atomist:autofix=typescript_imports]

@jessitron jessitron force-pushed the nortissej/extensionPackGen branch from 8a3957d to f74191c Feb 28, 2019

@jessitron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

I am aware that specifying "noImplicitAny" has no effect. I still like it. It doesn't matter

@jessitron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

I removed the @types moves, that is a different yak than these improvement

@jessitron jessitron marked this pull request as ready for review Feb 28, 2019

@owner

This comment has been minimized.

Copy link

commented on c5c7178 Mar 1, 2019

Include @owner in package name

for?

@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit 4c6449b into master Mar 15, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@atomist-bot atomist-bot deleted the nortissej/extensionPackGen branch Mar 15, 2019

atomist-bot added a commit that referenced this pull request Mar 15, 2019

Changelog: #236 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.