Fix validation issues for number configuration values

fixes #578
atomist · Nov 24, 2018 · 14715d8 · 14715d8
1 parent ebd2376
commit 14715d8
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/api/machine/ConfigurationValues.ts b/lib/api/machine/ConfigurationValues.ts
@@ -54,7 +54,7 @@ export function validateConfigurationValues(config: any, options: ConfigurationV
         } else {
             switch (type) {
                 case ConfigurationValueType.Number:
-                    if (!Number.isNaN(value)) {
+                    if (typeof value !== "number") {
                         invalidValues.push(`${path} ${JSON.stringify(value)} is not a 'number'`);
                     }
                     break;

diff --git a/test/api/mapping/ConfigureValues.test.ts → test/api/machine/ConfigureValues.test.ts b/test/api/mapping/ConfigureValues.test.ts → test/api/machine/ConfigureValues.test.ts
@@ -131,4 +131,15 @@ describe("validateConfigurationValues", () => {
         }
         done();
     });
+
+    it("should validate value with correct number type", done => {
+        const config = { sdm: { test: 3 } };
+        const requiredValues = [{ path: "sdm.test", type: ConfigurationValueType.Number }];
+        try {
+            validateConfigurationValues(config, { requiredConfigurationValues: requiredValues });
+        } catch (err) {
+            assert.fail();
+        }
+        done();
+    });
 });