New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review listeners that set goal result state #573

Merged
merged 1 commit into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@ddgenome
Copy link
Member

ddgenome commented Nov 13, 2018

Provide common review listeners that fail or require approval for
different review comments.

Fix automation-client peer dependency, although NPM semver still gets
it wrong. Update automation-client dev dependency and fix
compilation.

Remove GraphQL code generation peer dependencies and old schema files.

Update build package scripts.

Update ignored files.

Add review listeners that set goal result state
Provide common review listeners that fail or require approval for
different review comments.

Fix automation-client peer dependency, although NPM semver still gets
it wrong.  Update automation-client dev dependency and fix
compilation.

Remove GraphQL code generation peer dependencies and old schema files.

Update build package scripts.

Update ignored files.
@cdupuis
Copy link
Contributor

cdupuis left a comment

One question... See inline

Show resolved Hide resolved package.json

@ddgenome ddgenome removed the request for review from lievendoclo Nov 13, 2018

@cdupuis cdupuis merged commit 96d00b9 into master Nov 13, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the goal-review-listener branch Nov 13, 2018

atomist-bot added a commit that referenced this pull request Nov 13, 2018

Changelog: #573 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment