New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update child_process usage #584

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
2 participants
@ddgenome
Copy link
Member

ddgenome commented Nov 27, 2018

Update or deprecate functions that use deprecated child_process
functionality from automation-client. Provide equivalent
functionality for deprecated functions. Re-export functionality from
automation-client.

Clean up some interfaces. Specifically, ExecuteGoalResult
re-implemented HandlerResult and now it extends it. Similarly,
ProgressLog re-implemented WritableLog and now it extends it.

Update a few tslint rules and delint.

Remove unused dependencies and add missing types.

Closes #575

Show resolved Hide resolved lib/api/goal/ExecuteGoalResult.ts Outdated
Update child_process usage
Update or deprecate functions that use deprecated child_process
functionality from automation-client.  Provide equivalent
functionality for deprecated functions.  Re-export functionality from
automation-client.

ProgressLog re-implemented WritableLog and now it extends it.

Update a few tslint rules and delint.

Remove unused dependencies and add missing types.

Closes #575

@ddgenome ddgenome force-pushed the child-process-575 branch from b461ca7 to bda4953 Nov 28, 2018

@ddgenome ddgenome removed the request for review from johnsonr Nov 28, 2018

@cdupuis
Copy link
Contributor

cdupuis left a comment

Thanks @ddgenome

@cdupuis cdupuis assigned cdupuis and unassigned cdupuis Nov 28, 2018

@cdupuis cdupuis merged commit 568c8c7 into master Nov 28, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@cdupuis cdupuis deleted the child-process-575 branch Nov 28, 2018

atomist-bot added a commit that referenced this pull request Nov 28, 2018

Changelog: #584 to added, deprecated
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment