Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate the SHA on projects when loading them. #652

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@jessitron
Copy link
Contributor

commented Jan 6, 2019

The trigger for this is because we should have the SHA available in code inspections.
It is possible this will change something elsewhere. It seems like this is
useful to have generally. If it does cause problems, we could move it to only
do this on code inspections.

Populate the SHA on projects when loading them.
The trigger for this is because we should have the SHA available in code inspections.
It is possible this will change something elsewhere. It seems like this is
useful to have generally. If it does cause problems, we could move it to only
do this on code inspections.
@cdupuis

cdupuis approved these changes Jan 6, 2019

Copy link
Contributor

left a comment

LGTM

@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Jan 6, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit 056380b into master Jan 6, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@atomist-bot atomist-bot deleted the nortissej/populate-sha branch Jan 6, 2019

atomist-bot added a commit that referenced this pull request Jan 6, 2019

Changelog: #652 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.