Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make goal launching more pluggable #656

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

commented Jan 14, 2019

This PR introduces an improved extension point for launching goals. Several GaolLauncher instances can be registered; the first which supports method returns true will launch the goal.

This is a change in public API, but I don't expect anybody to have implemented a custom IsolatedGoalLauncher at this point.

cdupuis and others added some commits Jan 12, 2019

Autofix: TypeScript header
[atomist:generated] [atomist:autofix=typescript_header]
@ddgenome
Copy link
Member

left a comment

LGTM

@atomist-bot

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit ae78c49 into master Jan 14, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@atomist-bot atomist-bot deleted the goal-launching branch Jan 14, 2019

atomist-bot added a commit that referenced this pull request Jan 14, 2019

Changelog: #656 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.