Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a useful implementation of onTransformResults #666

Merged
merged 5 commits into from Feb 13, 2019

Conversation

Projects
None yet
4 participants
@jessitron
Copy link
Contributor

commented Jan 29, 2019

This is one way to get some notification when the save failed.

the story is: I made a transform with a colon in its name. When I ran it, it told me it was successful, because it didn't fail to edit the project. But it did fail to save those edits to a branch! It did not tell me!
Also it does not tell the branch when it succeeds; I have to go looking for it.

With this implementation of onTransformResults, I get a message in case of failure or success. It's very useful, I have wanted this a dozen times, and so it should be available in the library.

@jessitron jessitron requested a review from johnsonr Jan 29, 2019

@cdupuis
Copy link
Contributor

left a comment

Can we use the standard slack message formatting of slackInfoMessage etc for these, please?

Other then that, this looks really useful. Thanks.

jessitron and others added some commits Jan 29, 2019

Provide a useful implementation of onTransformResults
This is one way to get some notification when the save failed
Autofix: TypeScript header
[atomist:generated] [atomist:autofix=typescript_header]
Autofix: TypeScript imports
[atomist:generated] [atomist:autofix=typescript_imports]

@jessitron jessitron force-pushed the nortissej/onTransformResults branch from 6e6e2f6 to d20ddd1 Feb 4, 2019

jessitron and others added some commits Feb 4, 2019

Autofix: TypeScript imports
[atomist:generated] [atomist:autofix=typescript_imports]
@jessitron

This comment has been minimized.

Copy link
Contributor Author

commented Feb 4, 2019

@cdupuis like this?

@johnsonr johnsonr merged commit 960270f into master Feb 13, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details

@johnsonr johnsonr deleted the nortissej/onTransformResults branch Feb 13, 2019

atomist-bot added a commit that referenced this pull request Feb 13, 2019

Changelog: #666 to added
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.