New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AntProject#java for JRuby #2

Merged
merged 2 commits into from Jul 6, 2011

Conversation

Projects
None yet
2 participants
@thomaslee

thomaslee commented Jul 6, 2011

When calling the AntProject#java task from JRuby, #method_missing is not invoked due to all Objects implicitly getting a #java method on the JRuby platform.

This patch explicitly declares the #java method on AntProject so as to ensure that calls to #java get routed to #method_missing in JRuby -- as one would expect.

This was discovered during the development of buildr-mirah: http://github.com/thomaslee/buildr-mirah -- happy to reproduce this in isolation if it's helpful.

@atoulme

This comment has been minimized.

Owner

atoulme commented Jul 6, 2011

Looks fairly harmless. Will pull.

atoulme added a commit that referenced this pull request Jul 6, 2011

Merge pull request #2 from thomaslee/master
Fix AntProject#java for JRuby

@atoulme atoulme merged commit 6b75560 into atoulme:master Jul 6, 2011

@atoulme

This comment has been minimized.

Owner

atoulme commented Jul 6, 2011

Also, 0.7.2 is out with your patch. Enjoy.

@thomaslee

This comment has been minimized.

thomaslee commented Jul 7, 2011

Thanks for the speedy turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment