Skip to content
This repository was archived by the owner on Jul 2, 2026. It is now read-only.

Add cookies to the client (https://github.com/atoum/AtoumBundle/issues/5... - #52

Closed
Rebolon wants to merge 4 commits into
atoum:masterfrom
Rebolon:feature-addCookies
Closed

Rebolon wants to merge 4 commits into
atoum:masterfrom
Rebolon:feature-addCookies

Conversation

@Rebolon

@Rebolon Rebolon commented Oct 21, 2013

Copy link
Copy Markdown

...1)

@Rebolon

Rebolon commented Oct 21, 2013

Copy link
Copy Markdown
Author

Ok i launch it

@Rebolon

Rebolon commented Oct 21, 2013

Copy link
Copy Markdown
Author

This PR solve a part of the problem from issue #51

@nchaulet

Copy link
Copy Markdown
Contributor

👍

1 similar comment
@stephpy

stephpy commented Oct 22, 2013

Copy link
Copy Markdown
Member

👍

@jubianchi

Copy link
Copy Markdown
Member

:shipit:

@FlorianLB

Copy link
Copy Markdown
Member

What about adding $cookies as an option to the createClientmethod ?

@jubianchi

Copy link
Copy Markdown
Member

@FlorianLB +1

@Rebolon

Rebolon commented Oct 22, 2013

Copy link
Copy Markdown
Author

@FlorianLB so the new createClient method would look like this :

public function createClient(array $options = array(), array $server = array(), array $cookies = array())

I think it's a cool thing.
I change it now

@FlorianLB

Copy link
Copy Markdown
Member

Seems good for me.

@jubianchi

Copy link
Copy Markdown
Member

👍

@FlorianLB

Copy link
Copy Markdown
Member

Can you squash your commits ? I will merge this PR after.

@Rebolon

Rebolon commented Oct 22, 2013

Copy link
Copy Markdown
Author

What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ?

@FlorianLB

Copy link
Copy Markdown
Member

In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect.

You can rebase (and squash your commits during) on this branch, no need a new branch/PR.

If you can't do this, it doesn't matter.

@FlorianLB

Copy link
Copy Markdown
Member

Thx :)

@FlorianLB FlorianLB closed this Oct 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants