Add cookies to the client (https://github.com/atoum/AtoumBundle/issues/5... #52

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
5 participants
@Rebolon

Rebolon commented Oct 21, 2013

...1)

@jubianchi

This comment has been minimized.

Show comment
Hide comment
@jubianchi

jubianchi Oct 17, 2013

Count is not mandatory here as $cookies parameters is typehinted on array and has a default value.

Count is not mandatory here as $cookies parameters is typehinted on array and has a default value.

@jubianchi

This comment has been minimized.

Show comment
Hide comment
@jubianchi

jubianchi Oct 17, 2013

Go PR :) 👍

Go PR :) 👍

@Rebolon

This comment has been minimized.

Show comment
Hide comment
@Rebolon

Rebolon Oct 21, 2013

Ok i launch it

Rebolon commented Oct 21, 2013

Ok i launch it

@Rebolon

This comment has been minimized.

Show comment
Hide comment
@Rebolon

Rebolon Oct 21, 2013

This PR solve a part of the problem from issue #51

Rebolon commented Oct 21, 2013

This PR solve a part of the problem from issue #51

@nchaulet

This comment has been minimized.

Show comment
Hide comment
@nchaulet

nchaulet Oct 21, 2013

Contributor

👍

Contributor

nchaulet commented Oct 21, 2013

👍

@stephpy

This comment has been minimized.

Show comment
Hide comment
@stephpy

stephpy Oct 22, 2013

Member

👍

Member

stephpy commented Oct 22, 2013

👍

@jubianchi

This comment has been minimized.

Show comment
Hide comment
Member

jubianchi commented Oct 22, 2013

:shipit:

@FlorianLB

This comment has been minimized.

Show comment
Hide comment
@FlorianLB

FlorianLB Oct 22, 2013

Member

What about adding $cookies as an option to the createClientmethod ?

Member

FlorianLB commented Oct 22, 2013

What about adding $cookies as an option to the createClientmethod ?

@jubianchi

This comment has been minimized.

Show comment
Hide comment
Member

jubianchi commented Oct 22, 2013

@Rebolon

This comment has been minimized.

Show comment
Hide comment
@Rebolon

Rebolon Oct 22, 2013

@FlorianLB so the new createClient method would look like this :

public function createClient(array $options = array(), array $server = array(), array $cookies = array())

I think it's a cool thing.
I change it now

Rebolon commented Oct 22, 2013

@FlorianLB so the new createClient method would look like this :

public function createClient(array $options = array(), array $server = array(), array $cookies = array())

I think it's a cool thing.
I change it now

@FlorianLB

This comment has been minimized.

Show comment
Hide comment
@FlorianLB

FlorianLB Oct 22, 2013

Member

Seems good for me.

Member

FlorianLB commented Oct 22, 2013

Seems good for me.

@jubianchi

This comment has been minimized.

Show comment
Hide comment
@jubianchi

jubianchi Oct 22, 2013

Member

👍

Member

jubianchi commented Oct 22, 2013

👍

@FlorianLB

This comment has been minimized.

Show comment
Hide comment
@FlorianLB

FlorianLB Oct 22, 2013

Member

Can you squash your commits ? I will merge this PR after.

Member

FlorianLB commented Oct 22, 2013

Can you squash your commits ? I will merge this PR after.

@Rebolon

This comment has been minimized.

Show comment
Hide comment
@Rebolon

Rebolon Oct 22, 2013

What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ?

Rebolon commented Oct 22, 2013

What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ?

@FlorianLB

This comment has been minimized.

Show comment
Hide comment
@FlorianLB

FlorianLB Oct 22, 2013

Member

In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect.

You can rebase (and squash your commits during) on this branch, no need a new branch/PR.

If you can't do this, it doesn't matter.

Member

FlorianLB commented Oct 22, 2013

In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect.

You can rebase (and squash your commits during) on this branch, no need a new branch/PR.

If you can't do this, it doesn't matter.

@FlorianLB

This comment has been minimized.

Show comment
Hide comment
@FlorianLB

FlorianLB Oct 22, 2013

Member

Thx :)

Member

FlorianLB commented Oct 22, 2013

Thx :)

@FlorianLB FlorianLB closed this Oct 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment