New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookies to the client (https://github.com/atoum/AtoumBundle/issues/5... #52
Conversation
Ok i launch it |
This PR solve a part of the problem from issue #51 |
👍 |
1 similar comment
👍 |
|
What about adding |
@FlorianLB +1 |
@FlorianLB so the new createClient method would look like this : public function createClient(array $options = array(), array $server = array(), array $cookies = array()) I think it's a cool thing. |
Seems good for me. |
👍 |
Can you squash your commits ? I will merge this PR after. |
What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ? |
In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect. You can rebase (and squash your commits during) on this branch, no need a new branch/PR. If you can't do this, it doesn't matter. |
Thx :) |
...1)