Add cookies to the client (https://github.com/atoum/AtoumBundle/issues/5...

[Rebolon]

...1)

[jubianchi]

Count is not mandatory here as $cookies parameters is typehinted on array and has a default value.

[jubianchi]

Go PR :) 👍

[Rebolon]

Ok i launch it

[Rebolon]

This PR solve a part of the problem from issue #51

[nchaulet]

👍

[stephpy]

👍

[jubianchi]

[FlorianLB]

What about adding $cookies as an option to the createClientmethod ?

[jubianchi]

@FlorianLB +1

[Rebolon]

@FlorianLB so the new createClient method would look like this :

public function createClient(array $options = array(), array $server = array(), array $cookies = array())

I think it's a cool thing.
I change it now

[FlorianLB]

Seems good for me.

[jubianchi]

👍

[FlorianLB]

Can you squash your commits ? I will merge this PR after.

[Rebolon]

What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ?

[FlorianLB]

In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect.

You can rebase (and squash your commits during) on this branch, no need a new branch/PR.

If you can't do this, it doesn't matter.

[FlorianLB]

Thx :)