Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookies to the client (https://github.com/atoum/AtoumBundle/issues/5... #52

Closed
wants to merge 4 commits into from

Conversation

@Rebolon
Copy link

@Rebolon Rebolon commented Oct 21, 2013

...1)

Benjamin RICHARD
@jubianchi

This comment has been minimized.

Copy link

@jubianchi jubianchi commented on Test/Units/WebTestCase.php in 882254c Oct 17, 2013

Count is not mandatory here as $cookies parameters is typehinted on array and has a default value.

@jubianchi

This comment has been minimized.

Copy link

@jubianchi jubianchi commented on 882254c Oct 17, 2013

Go PR :) 👍

@Rebolon
Copy link
Author

@Rebolon Rebolon commented Oct 21, 2013

Ok i launch it

Benjamin RICHARD added 2 commits Oct 21, 2013
Benjamin RICHARD
Benjamin RICHARD
@Rebolon
Copy link
Author

@Rebolon Rebolon commented Oct 21, 2013

This PR solve a part of the problem from issue #51

@nchaulet
Copy link
Contributor

@nchaulet nchaulet commented Oct 21, 2013

👍

1 similar comment
@stephpy
Copy link
Member

@stephpy stephpy commented Oct 22, 2013

👍

@jubianchi
Copy link
Member

@jubianchi jubianchi commented Oct 22, 2013

:shipit:

@FlorianLB
Copy link
Member

@FlorianLB FlorianLB commented Oct 22, 2013

What about adding $cookies as an option to the createClientmethod ?

@jubianchi
Copy link
Member

@jubianchi jubianchi commented Oct 22, 2013

@Rebolon
Copy link
Author

@Rebolon Rebolon commented Oct 22, 2013

@FlorianLB so the new createClient method would look like this :

public function createClient(array $options = array(), array $server = array(), array $cookies = array())

I think it's a cool thing.
I change it now

@FlorianLB
Copy link
Member

@FlorianLB FlorianLB commented Oct 22, 2013

Seems good for me.

@jubianchi
Copy link
Member

@jubianchi jubianchi commented Oct 22, 2013

👍

@FlorianLB
Copy link
Member

@FlorianLB FlorianLB commented Oct 22, 2013

Can you squash your commits ? I will merge this PR after.

@Rebolon
Copy link
Author

@Rebolon Rebolon commented Oct 22, 2013

What is the aim of this squash ? won't we loose the history of this PR because i have to push on a new branch and do a new PR, am i wrong ?

@FlorianLB
Copy link
Member

@FlorianLB FlorianLB commented Oct 22, 2013

In the commit history we don't need to see the different iterations of a PR. For a "simple" change like this one, only one commit is perfect.

You can rebase (and squash your commits during) on this branch, no need a new branch/PR.

If you can't do this, it doesn't matter.

@FlorianLB
Copy link
Member

@FlorianLB FlorianLB commented Oct 22, 2013

Thx :)

@FlorianLB FlorianLB closed this Oct 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants