Skip to content
This repository was archived by the owner on Jul 2, 2026. It is now read-only.

add ci configuration to lint examples - #210

Merged
Grummfy merged 1 commit into
atoum:masterfrom
agallou:ci_lint_examples
Jun 2, 2016
Merged

Grummfy merged 1 commit into
atoum:masterfrom
agallou:ci_lint_examples

Conversation

@agallou

@agallou agallou commented May 29, 2016

Copy link
Copy Markdown
Member

No description provided.

@agallou
agallou force-pushed the ci_lint_examples branch 2 times, most recently from c0ed758 to d9f72ff Compare May 29, 2016 22:09
@agallou

agallou commented May 29, 2016

Copy link
Copy Markdown
Member Author

We van see a build example here : https://travis-ci.org/atoum/atoum-documentation/builds/133798215

Here is a sample of the output :

⚑ Analysing file source//en/annotations.rst
⚑ Analysing file source//en/annotations/annotation-extension.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/annotation-php.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/data-provider.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters.rst
⚑ Analysing file source//en/asserters/afterDestructionOf.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters/array.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected

Thanks to @K-Phoen for the linter.

@Grummfy

Grummfy commented May 30, 2016

Copy link
Copy Markdown
Member

We should a some more stuff :

  • a helper or a command to run it locally ?
  • in the README : how to run it locally to validate the changes

@K-Phoen

K-Phoen commented May 30, 2016

Copy link
Copy Markdown

Would it be easier for you if Rusty provided downloadable .phar executables? :)

@jubianchi

Copy link
Copy Markdown
Member

@K-Phoen I'm not a super fan of Phar: it makes dealing with dependencie harder than with composer. Here we only have to put something in the json and composer deals with downloading, linking and locking everything ;)

@agallou

agallou commented May 30, 2016

Copy link
Copy Markdown
Member Author

ok. I will add both composer.json and composer.lock in the repository, and drop some lines about it in the readme.

@agallou
agallou force-pushed the ci_lint_examples branch from d9f72ff to 7c79bc0 Compare May 30, 2016 20:12
@agallou

agallou commented May 30, 2016

Copy link
Copy Markdown
Member Author

PR updated with composer.json and composer.lock files commited, and documentation in README.md

@Grummfy
Grummfy merged commit fdf9d89 into atoum:master Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants