add ci configuration to lint examples #210

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@agallou
Member

agallou commented May 29, 2016

No description provided.

@agallou

This comment has been minimized.

Show comment
Hide comment
@agallou

agallou May 29, 2016

Member

We van see a build example here : https://travis-ci.org/atoum/atoum-documentation/builds/133798215

Here is a sample of the output :

⚑ Analysing file source//en/annotations.rst
⚑ Analysing file source//en/annotations/annotation-extension.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/annotation-php.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/data-provider.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters.rst
⚑ Analysing file source//en/asserters/afterDestructionOf.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters/array.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected

Thanks to @K-Phoen for the linter.

Member

agallou commented May 29, 2016

We van see a build example here : https://travis-ci.org/atoum/atoum-documentation/builds/133798215

Here is a sample of the output :

⚑ Analysing file source//en/annotations.rst
⚑ Analysing file source//en/annotations/annotation-extension.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/annotation-php.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/data-provider.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters.rst
⚑ Analysing file source//en/asserters/afterDestructionOf.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters/array.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected

Thanks to @K-Phoen for the linter.

@Grummfy

This comment has been minimized.

Show comment
Hide comment
@Grummfy

Grummfy May 30, 2016

Member

We should a some more stuff :

  • a helper or a command to run it locally ?
  • in the README : how to run it locally to validate the changes
Member

Grummfy commented May 30, 2016

We should a some more stuff :

  • a helper or a command to run it locally ?
  • in the README : how to run it locally to validate the changes
@K-Phoen

This comment has been minimized.

Show comment
Hide comment
@K-Phoen

K-Phoen May 30, 2016

Would it be easier for you if Rusty provided downloadable .phar executables? :)

K-Phoen commented May 30, 2016

Would it be easier for you if Rusty provided downloadable .phar executables? :)

@jubianchi

This comment has been minimized.

Show comment
Hide comment
@jubianchi

jubianchi May 30, 2016

Member

@K-Phoen I'm not a super fan of Phar: it makes dealing with dependencie harder than with composer. Here we only have to put something in the json and composer deals with downloading, linking and locking everything ;)

Member

jubianchi commented May 30, 2016

@K-Phoen I'm not a super fan of Phar: it makes dealing with dependencie harder than with composer. Here we only have to put something in the json and composer deals with downloading, linking and locking everything ;)

@agallou

This comment has been minimized.

Show comment
Hide comment
@agallou

agallou May 30, 2016

Member

ok. I will add both composer.json and composer.lock in the repository, and drop some lines about it in the readme.

Member

agallou commented May 30, 2016

ok. I will add both composer.json and composer.lock in the repository, and drop some lines about it in the readme.

@agallou

This comment has been minimized.

Show comment
Hide comment
@agallou

agallou May 30, 2016

Member

PR updated with composer.json and composer.lock files commited, and documentation in README.md

Member

agallou commented May 30, 2016

PR updated with composer.json and composer.lock files commited, and documentation in README.md

@Grummfy Grummfy merged commit fdf9d89 into atoum:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment