Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci configuration to lint examples #210

Merged
merged 1 commit into from Jun 2, 2016
Merged

Conversation

@agallou
Copy link
Member

agallou commented May 29, 2016

No description provided.

@agallou agallou force-pushed the agallou:ci_lint_examples branch 2 times, most recently from c0ed758 to d9f72ff May 29, 2016
@agallou
Copy link
Member Author

agallou commented May 29, 2016

We van see a build example here : https://travis-ci.org/atoum/atoum-documentation/builds/133798215

Here is a sample of the output :

⚑ Analysing file source//en/annotations.rst
⚑ Analysing file source//en/annotations/annotation-extension.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/annotation-php.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/annotations/data-provider.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters.rst
⚑ Analysing file source//en/asserters/afterDestructionOf.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
⚑ Analysing file source//en/asserters/array.inc.rst
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected
 → Found code sample in line 0
 ✔ No syntax error detected

Thanks to @K-Phoen for the linter.

@Grummfy
Copy link
Member

Grummfy commented May 30, 2016

We should a some more stuff :

  • a helper or a command to run it locally ?
  • in the README : how to run it locally to validate the changes
@K-Phoen
Copy link

K-Phoen commented May 30, 2016

Would it be easier for you if Rusty provided downloadable .phar executables? :)

@jubianchi
Copy link
Member

jubianchi commented May 30, 2016

@K-Phoen I'm not a super fan of Phar: it makes dealing with dependencie harder than with composer. Here we only have to put something in the json and composer deals with downloading, linking and locking everything ;)

@agallou
Copy link
Member Author

agallou commented May 30, 2016

ok. I will add both composer.json and composer.lock in the repository, and drop some lines about it in the readme.

@agallou agallou force-pushed the agallou:ci_lint_examples branch from d9f72ff to 7c79bc0 May 30, 2016
@agallou
Copy link
Member Author

agallou commented May 30, 2016

PR updated with composer.json and composer.lock files commited, and documentation in README.md

@Grummfy Grummfy merged commit fdf9d89 into atoum:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.