Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix mock generated method signature with callable type hint #210
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Please add the unit test. |
added some commits
Apr 29, 2013
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Done. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mageekguy
Apr 29, 2013
Contributor
I think that your test failed with PHP 5.3 because reflectionMethod::isCallable() does not exist with this version.
|
I think that your test failed with PHP 5.3 because |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
adriensamson
Apr 30, 2013
Contributor
Yes. That's why I added a method_exists call in the generator and skipped the test for 5.3
|
Yes. That's why I added a |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mageekguy
Apr 30, 2013
Contributor
Oh sorry, i have don't see the annotation in the test (note for later: do not review PR at midnight ;)).
|
Oh sorry, i have don't see the annotation in the test (note for later: do not review PR at midnight ;)). |
mageekguy
reviewed
Apr 30, 2013
classes/mock/generator.php
| @@ -409,6 +409,10 @@ protected static function getParameterType(\reflectionParameter $parameter) | ||
| { | ||
| $type = 'array '; | ||
| } | ||
| elseif (method_exists($parameter, 'isCallable') && $parameter->isCallable() == true) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mageekguy
Apr 30, 2013
Contributor
Please use switch(true) { case $parameter->isArray(): … instead of if… else if … else.
mageekguy
Apr 30, 2013
Contributor
Please use switch(true) { case $parameter->isArray(): … instead of if… else if … else.
adriensamson commentedApr 29, 2013
This PR fixes the generated mock class when one of its methods has a 'callable' type hint.