Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window size option #123

Merged
merged 10 commits into from Apr 24, 2019
Merged

Add window size option #123

merged 10 commits into from Apr 24, 2019

Conversation

@iwatakeshi
Copy link
Contributor

iwatakeshi commented Apr 23, 2019

This adds the --window-size option to the argument list. Two of the Travis builds are failing but it seems irrelevant to the changes I made. If this is something I need to take care of, please let me know.

@lukaslueg
Copy link
Collaborator

lukaslueg commented Apr 23, 2019

Thanks for the PR!

Personally, I'd prefer to not change default behaviour if this option is not set. That said, the default behaviour should be to not pass any arg, instead of passing 1920x1080.

The Travis failings are due to clippy getting updated. I'd be helpful if you could fix them in this PR, even though unrelated. You can basically do what clippy suggests to do.

@iwatakeshi
Copy link
Contributor Author

iwatakeshi commented Apr 23, 2019

👍 understandable.

iwatakeshi added 4 commits Apr 23, 2019
@iwatakeshi
Copy link
Contributor Author

iwatakeshi commented Apr 23, 2019

@lukaslueg Would this be good? Thanks!

@atroche
Copy link
Owner

atroche commented Apr 24, 2019

Awesome, thanks @iwatakeshi!

@atroche atroche merged commit 6219769 into atroche:master Apr 24, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@iwatakeshi iwatakeshi deleted the iwatakeshi:add-window-size branch Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.