Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome paths #126

Merged
merged 9 commits into from May 8, 2019
Merged

Conversation

@iwatakeshi
Copy link
Contributor

iwatakeshi commented May 5, 2019

This adds additional paths to default_executable(). It also adds a check for an environment variable that may contain a path to the executable.

I wasn't sure if $CHROME would be a good variable. I thought $BROWSER was too generic and may imply that Firefox or another browser can be accepted. If you like me to change it to $BROWSER, please let me know. Thanks.

@lukaslueg
Copy link
Collaborator

lukaslueg commented May 8, 2019

@atroche are you seeing this? I think this is good to go if squashed.

@iwatakeshi Could you add some docs to default_executable() which strategies the function will try in which order? Something to the tune of "If the CHROME-env variable is defined, it is used. Otherwise the following filenames are searched for......."

iwatakeshi and others added 3 commits May 8, 2019
@lukaslueg lukaslueg merged commit f29e7b5 into atroche:master May 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.