Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: links from CONTRIBUTING.md to atGitHub.md #1029

Merged
merged 2 commits into from Nov 8, 2022
Merged

Conversation

cpswan
Copy link
Member

@cpswan cpswan commented Nov 7, 2022

[skip ci] docs: links from CONTRIBUTING.md to atGitHub.md

@cpswan cpswan requested a review from gkc November 7, 2022 15:08
@cpswan cpswan self-assigned this Nov 7, 2022
gkc
gkc previously approved these changes Nov 7, 2022
@gkc gkc changed the title [skip ci] docs: links from CONTRIBUTING.md to atGitHub.md docs: [skip ci] links from CONTRIBUTING.md to atGitHub.md Nov 7, 2022
@gkc gkc changed the title docs: [skip ci] links from CONTRIBUTING.md to atGitHub.md [skip ci] docs: links from CONTRIBUTING.md to atGitHub.md Nov 7, 2022
@gkc
Copy link
Contributor

gkc commented Nov 7, 2022

@cpswan can't merge this one

@cpswan cpswan changed the title [skip ci] docs: links from CONTRIBUTING.md to atGitHub.md docs: links from CONTRIBUTING.md to atGitHub.md Nov 7, 2022
@cpswan
Copy link
Member Author

cpswan commented Nov 7, 2022

@gkc it couldn't be merged because of [skip ci], which was a learning process for me, and something I know to turn off in git-xargs going forward.

I've managed to prod it into running tests now, but that's undone your earlier approval :(

@cpswan cpswan merged commit f503cad into trunk Nov 8, 2022
@cpswan cpswan deleted the cpswan-contributing.md branch May 3, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants